♻️ Route settings commands through dedicated settings handler#253
Merged
Conversation
Gudsfile
changed the title
Gudsfile
force-pushed
the
refactor/phase-3-admin-cli-boundaries
branch
2 times, most recently
from
1ad5b63 to
82f5b2d
Compare
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
a2ba362 to
2667dc6
Compare
Gudsfile
force-pushed
the
refactor/phase-3-admin-cli-boundaries
branch
3 times, most recently
from
0072ccb to
33854da
Compare
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
2667dc6 to
d9ef311
Compare
Gudsfile
force-pushed
the
refactor/phase-3-admin-cli-boundaries
branch
from
ec69ef0 to
6d1af7b
Compare
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
d9ef311 to
2e9f15e
Compare
Gudsfile
force-pushed
the
refactor/phase-3-admin-cli-boundaries
branch
from
6d1af7b to
232695c
Compare
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
2 times, most recently
from
ff6bc8c to
484d589
Compare
msgerbush
force-pushed
the
refactor/phase-3-admin-cli-boundaries
branch
from
232695c to
37db220
Compare
msgerbush
previously approved these changes
May 13, 2026
Gudsfile
force-pushed
the
refactor/phase-3-admin-cli-boundaries
branch
2 times, most recently
from
cd3c9bd to
a7cd861
Compare
Settings commands now use build_settings_service directly instead of build_admin_services, avoiding unnecessary Sonos service instantiation. _run_settings_command mirrors the library command pattern and allows settings queries to succeed even when the full admin runtime cannot resolve.
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
484d589 to
dbb7aa8
Compare
Collaborator
|
Sorry, accidentally did a merge update instead of rebase :/ |
msgerbush
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
Summary
_run_settings_commandhandler, separate from the generic_run_commandsettings_serviceviabuild_settings_service, bypassingbuild_admin_servicesentirely: commands can execute even if the admin runtime fails to initialize